fix: check _config.escapeFormulae is true #1025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing the config with a boolean value of
escapeFormulae
, the presence of theescapeFormulae
key is checked but the value itself is not checked.This means that
_config = {escapeFormulae: false}
behaves the same as_config = {escapeFormulae: true}
.Codesandbox example
Result
This PR adds a check that
escapeFormulae
is truthy before using the default regex for escaping formulae.